-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Large fluid pump+Biome property #327
Merged
bruberu
merged 21 commits into
SymmetricDevs:main
from
trainvoi:LargeFluidPump+BiomeProperty
Oct 24, 2024
Merged
Large fluid pump+Biome property #327
bruberu
merged 21 commits into
SymmetricDevs:main
from
trainvoi:LargeFluidPump+BiomeProperty
Oct 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BiomeProperty implementation
…invoi/Susy-Core into LargeFluidPump+BiomeProperty
MCTian-mi
requested changes
Oct 21, 2024
src/main/java/supersymmetry/api/capability/impl/BiomeRecipeLogic.java
Outdated
Show resolved
Hide resolved
src/main/java/supersymmetry/common/metatileentities/SuSyMetaTileEntities.java
Outdated
Show resolved
Hide resolved
.../java/supersymmetry/common/metatileentities/multi/electric/MetaTileEntityLargeFluidPump.java
Outdated
Show resolved
Hide resolved
MCTian-mi
requested changes
Oct 21, 2024
src/main/java/supersymmetry/api/capability/impl/BiomeRecipeLogic.java
Outdated
Show resolved
Hide resolved
.../java/supersymmetry/common/metatileentities/multi/electric/MetaTileEntityLargeFluidPump.java
Show resolved
Hide resolved
trainvoi
force-pushed
the
LargeFluidPump+BiomeProperty
branch
from
October 21, 2024 10:04
510c082
to
db63aa2
Compare
…invoi/Susy-Core into LargeFluidPump+BiomeProperty
MCTian-mi
requested changes
Oct 21, 2024
.../java/supersymmetry/common/metatileentities/multi/electric/MetaTileEntityLargeFluidPump.java
Outdated
Show resolved
Hide resolved
trainvoi
force-pushed
the
LargeFluidPump+BiomeProperty
branch
from
October 21, 2024 13:11
1534f9c
to
222190f
Compare
MCTian-mi
approved these changes
Oct 22, 2024
bruberu
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new changes lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Large Fluid Pump multiblock + Biome Property from #323 by TianMi
Feature:
Missing feature (not yet implemented):